[UR][OpenCL] Save the function pointer for clSetKernelArgMemPointerINTEL per kernel #18103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarongreig
reviewed
Apr 21, 2025
aarongreig
approved these changes
Apr 21, 2025
|
I looked at the failing checks and I don't think they're caused by my changes. Is any action required on my end? Should I investigate further, or move to a newer tag? |
I gave them a retry, if its persistent then pulling in latest sycl branch would be a reasonable next step. |
This eliminates the need to query the context for the kernel and look up the function pointer in the extension function pointer cache each time a pointer is set as a kernel argument. Signed-off-by: Ben Ashbaugh <[email protected]>
Because CL_INVALID_VALUE is returned both when the size of the value being queried is incorrect and when the information being queried is unrecognized, it is difficult to differentiate between the UR INVALID_SIZE and UNSUPPORTED_ENUMERATION errors. For now, we will check for and return INVALID_SIZE first, which is what the tests are expecting.
bashbaug
force-pushed
the
urocl-kernel-improvements
branch
from
24f0ce3 to
c86d2fc
Compare
bashbaug
force-pushed
the
urocl-kernel-improvements
branch
from
c649022 to
c86d2fc
Compare
|
Great, I updated to a newer tag and it looks like all tests are passing now 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saves the function pointer for clSetKernelArgMemPointerINTEL when the kernel is created. This eliminates the need to query the context for the kernel and look up the function pointer in the extension function pointer cache each time a pointer is set as a kernel argument.
Additionally: