Skip to content

[DeviceMSAN] Fix e2e tests crashed on OpenCL CPU #18150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 23, 2025

Conversation

AllanZyne
Copy link
Contributor

@AllanZyne AllanZyne commented Apr 23, 2025

Unlike ASAN, MSAN needs "__devicelib_exit()" because if "j" is an uninitialized value in "data[j]", this will cause memory crash on CPU.
But sometimes "__devicelib_exit()" will hang on OpenMP (GPU), so I added a new option "recover" to control it.

@AllanZyne AllanZyne requested a review from a team as a code owner April 23, 2025 08:44
@AllanZyne AllanZyne requested a review from a team as a code owner April 23, 2025 08:58
@AllanZyne
Copy link
Contributor Author

@intel/unified-runtime-reviewers, please review, thanks!

@AllanZyne
Copy link
Contributor Author

@intel/llvm-gatekeepers, please merge, thanks!

@kbenzie kbenzie merged commit 205449a into sycl Apr 23, 2025
34 checks passed
@AllanZyne AllanZyne deleted the review/yang/fix_msan_exit branch April 24, 2025 00:55
KornevNikita pushed a commit that referenced this pull request May 27, 2025
Unlike ASAN, MSAN needs "__devicelib_exit()" because if "j" is an
uninitialized value in "data[j]", this will cause memory crash on CPU.
But sometimes "__devicelib_exit()" will hang on OpenMP (GPU), so I added
a new option "recover" to control it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants