[SYCL] Adjust Messaging for Invalid NDRange WorkGroup Sizes #1817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s of global, but this is likely not correct for OpenCL 2.0. Signed-off-by: Chris Perkins <[email protected]>
Signed-off-by: Chris Perkins <[email protected]>
Signed-off-by: Chris Perkins <[email protected]>
Signed-off-by: Chris Perkins <[email protected]>
v-klochkov
reviewed
Jun 5, 2020
Signed-off-by: Chris Perkins <[email protected]>
romanovvlad
reviewed
Jun 8, 2020
v-klochkov
approved these changes
Jun 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the error messages thrown when the workgroup sizes for a kernel invocation are invalid. It more accurately informs the user when the global workgroup size is not evenly divisible by the local work size, and when the local size is greater than the global. Messaging in the more limited OpenCL 2.0 cases (where there are fewer size restrictions is likewise improved
Signed-off-by: Chris Perkins [email protected]