Skip to content

[SYCL][E2E] fix quote_path bug in lit config #18218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 28, 2025

Conversation

yingcong-wu
Copy link
Contributor

@yingcong-wu yingcong-wu commented Apr 28, 2025

The quote_path bug does not only affecting Windows(#18135) but also Linux. This patch address this problem. This bug affects all usage of quote_path, notably the level_zero_dev_kit feature.

zsh$> cat 1.py
import shlex
ret = shlex.quote('')
if ret:
    print("bug!")
else:
    print("not a problem")

zsh$> python3 1.py
bug!

@yingcong-wu yingcong-wu requested a review from a team as a code owner April 28, 2025 11:13
@yingcong-wu yingcong-wu changed the title save [SYCL][E2E] fix quote_path bug in lit config Apr 28, 2025
@sarnex sarnex merged commit 19668be into intel:sycl Apr 28, 2025
25 checks passed
@aelovikov-intel
Copy link
Contributor

These:

Failed Tests (3):
SYCL :: Adapters/level_zero/interop-get-native-mem.cpp
SYCL :: Graph/Explicit/interop-level-zero-get-native-mem.cpp
SYCL :: Graph/RecordReplay/interop-level-zero-get-native-mem.cpp

are failing in post commit since this PR. @yingcong-wu , @sarnex , any ideas?

@sarnex
Copy link
Contributor

sarnex commented Apr 30, 2025

I can't imagine it's from this PR but I'm fixing the failure in #18274

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants