Skip to content

[SYCL][NFC] Removed unused arguments in addHostAccessor #1830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 8, 2020
Merged

[SYCL][NFC] Removed unused arguments in addHostAccessor #1830

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions sycl/source/detail/scheduler/graph_builder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,8 +393,7 @@ Command *Scheduler::GraphBuilder::addCopyBack(Requirement *Req) {

// The function implements SYCL host accessor logic: host accessor
// should provide access to the buffer in user space.
Command *Scheduler::GraphBuilder::addHostAccessor(Requirement *Req,
const bool destructor) {
Command *Scheduler::GraphBuilder::addHostAccessor(Requirement *Req) {

const QueueImplPtr &HostQueue = getInstance().getDefaultHostQueue();

Expand Down
5 changes: 2 additions & 3 deletions sycl/source/detail/scheduler/scheduler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,12 +170,11 @@ void Scheduler::removeMemoryObject(detail::SYCLMemObjI *MemObj) {
MGraphBuilder.removeRecordForMemObj(MemObj);
}

EventImplPtr Scheduler::addHostAccessor(Requirement *Req,
const bool destructor) {
EventImplPtr Scheduler::addHostAccessor(Requirement *Req) {
std::unique_lock<std::shared_timed_mutex> Lock(MGraphLock, std::defer_lock);
lockSharedTimedMutex(Lock);

Command *NewCmd = MGraphBuilder.addHostAccessor(Req, destructor);
Command *NewCmd = MGraphBuilder.addHostAccessor(Req);

if (!NewCmd)
return nullptr;
Expand Down
4 changes: 2 additions & 2 deletions sycl/source/detail/scheduler/scheduler.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,7 +410,7 @@ class Scheduler {
/// \param Req is the requirement to be updated.
/// \return an event which indicates when these nodes are completed
/// and host accessor is ready for use.
EventImplPtr addHostAccessor(Requirement *Req, const bool Destructor = false);
EventImplPtr addHostAccessor(Requirement *Req);

/// Unblocks operations with the memory object.
///
Expand Down Expand Up @@ -472,7 +472,7 @@ class Scheduler {
/// Enqueues a command to create a host accessor.
///
/// \param Req points to memory being accessed.
Command *addHostAccessor(Requirement *Req, const bool destructor = false);
Command *addHostAccessor(Requirement *Req);

/// [Provisional] Optimizes the whole graph.
void optimize();
Expand Down