-
Notifications
You must be signed in to change notification settings - Fork 787
[SYCL] Implement sycl_khr_queue_empty_query #18308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Hu, Peisen <[email protected]>
Signed-off-by: Hu, Peisen <[email protected]>
@HPS-1 overall looks good, but should we wait for khronos specification to be merged first? |
Signed-off-by: Hu, Peisen <[email protected]>
Signed-off-by: Hu, Peisen <[email protected]>
…acro Signed-off-by: Hu, Peisen <[email protected]>
As suggested by Alexey, there's actually a 'deadlock' here, because the SYCL-Docs PR won't be merged until we implement that. So as described in https://github.com/intel/llvm/blob/sycl/sycl/doc/developer/KHRExtensions.md, we need to put our implementation under macro |
Implement
khr_empty()
undersycl_khr_queue_empty_query
(see KhronosGroup/SYCL-Docs#700), which is essentially the same asext_oneapi_empty()
undersycl_ext_oneapi_queue_empty
(https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/supported/sycl_ext_oneapi_queue_empty.asciidoc), and create respective test cases.Note: the change of adding
__DPCPP_ENABLE_UNFINISHED_KHR_EXTENSIONS
insycl/source/CMakeLists.txt
is to make surekhr_empty
's implementation get successfully compiled when compiling runtime. (Otherwise there will be a "no declaration matches" error since the declaration forkhr_empty
insycl/include/sycl/queue.hpp
is guarded under#ifdef __DPCPP_ENABLE_UNFINISHED_KHR_EXTENSIONS
)