[CI] Test on all devices when not specified #18356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sarnie, Nick <[email protected]>
sarnex
changed the title
|
PVC fail unrelated, fixed in HEAD |
Is this actually true? I thought we could have it set on build-only and it would just ignore it instead. |
In terms of the implementation yes, but if we require it then we would have to specify it on workflow calls doing only build which seems weird |
ayylol
approved these changes
May 9, 2025
Signed-off-by: Sarnie, Nick <[email protected]>
aelovikov-intel
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nightly https://github.com/intel/llvm/actions/runs/14892412297
We forgot to set
target_deviceswhen moving the nightly Windows run-tests job over to the composite workflow, but we can't require it to be set because it needs to be unset forbuild-onlymode, so just useallif not specified and fix the nightly.Currently we get a CMake error because
sycl_devicesis empty which fails to be parsed.