-
Notifications
You must be signed in to change notification settings - Fork 788
[SYCL] Implement SYCL_INTEL_enqueue_barrier DPC++ extension #1836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL] Implement SYCL_INTEL_enqueue_barrier DPC++ extension #1836
Conversation
Signed-off-by: Dmitry Vodopyanov <[email protected]>
Signed-off-by: Dmitry Vodopyanov <[email protected]>
Signed-off-by: Dmitry Vodopyanov <[email protected]>
Signed-off-by: Dmitry Vodopyanov <[email protected]>
Signed-off-by: Dmitry Vodopyanov <[email protected]>
Signed-off-by: Dmitry Vodopyanov <[email protected]>
Signed-off-by: Dmitry Vodopyanov <[email protected]>
Signed-off-by: Dmitry Vodopyanov <[email protected]>
…ier-implementation
…naming Signed-off-by: Dmitry Vodopyanov <[email protected]>
Signed-off-by: Dmitry Vodopyanov <[email protected]>
Signed-off-by: Dmitry Vodopyanov <[email protected]>
It's Upd: not on |
….cpp Signed-off-by: Dmitry Vodopyanov <[email protected]>
@smaslov-intel I fixed segmentation fault in @jbrodman could you review, please? |
Signed-off-by: Dmitry Vodopyanov <[email protected]>
@dm-vodopyanov, please, update your branch to fix the pre-commit tests. |
…d-SYCL_INTEL_enqueue_barrier-implementation
@bader Thanks! Updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This patch adds the implementation of SYCL_INTEL_enqueue_barrier DPC++ extension.
There are situations where defining dependencies based on events is more explicit than desired or required by an application. For instance, the user may know that a given task depends on all previously submitted tasks. Instead of explicitly adding all the required
handler::depends_on
calls, the user could express this intent via a single call, making the program more concise and explicit.To simplify the interface, this extension adds two new members to the
handler
class, and two new members to thequeue
class:handler::barrier :
void barrier()
andvoid barrier(const vector_class<event> &WaitList)
queue::submit_barrier :
event submit_barrier()
andevent submit_barrier(const vector_class<event> &WaitList)