[SYCL][NATIVECPU] fix for urEnqueueUSMFill when pattern size is equal to fill size #18366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uwedolinsky
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
uwedolinsky
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
hvdijk
approved these changes
May 9, 2025
|
@intel/llvm-gatekeepers this looks ready to merge. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
urEnqueueUSMFillin the NativeCPU adapter to correctly returnUR_RESULT_SUCCESSwhen the pattern size is equal to the fill size (previously returnedUR_RESULT_ERROR_INVALID_SIZE).This fixes at least
test-e2e/Basic/memop/memop_no_unnamed_lambda.cppon NativeCPU.This PR also removes an unneeded multiply in that function.