[UR][L0 Adapter] Fix an OOB access #18373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wu, Yingcong <[email protected]>
yingcong-wu
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR addresses an out-of-bound access issue where WorkDim values less than 3 were not being correctly handled.
- Replaces multiple fixed-index assertions and assignments with a loop that iterates over WorkDim
- Ensures that only valid dimensions are processed to prevent out-of-bound access
igchor
approved these changes
May 9, 2025
|
Hi @intel/llvm-gatekeepers , this PR is ready to merge, thanks. |
|
It looks like this is breaking the UR CTS pre-commit, see: |
yingcong-wu
added a commit
that referenced
this pull request
May 12, 2025
This reverts commit 65cf13e.
Yes, I will open a PR to address this problem promptly. |
|
PR open: #18408 |
|
Thank you @npmiller for reporting this. I really appreciate it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
WorkDimis not respected in the process, leading to an OOB access whenWorkDim < 3.