-
Notifications
You must be signed in to change notification settings - Fork 788
[SYCL] Accessor tags, CTAD and host_accessor #1838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: iburylov <[email protected]>
Signed-off-by: iburylov <[email protected]>
Signed-off-by: iburylov <[email protected]>
@mkinsner @jbrodman @rolandschulz |
My local runs fail two abi tests:
The reason:
What should I do: change the abi tests or make legacy declaration main one? |
I suggest making legacy declaration main one. |
Signed-off-by: iburylov <[email protected]>
Do tests need to be rerun or are there outstanding issues? |
@iburyl, can we rely on merging this patch till the next Monday? |
I would like to see this patch committed ASAP. |
Fix comment in property list Co-authored-by: Sergey Semenov <[email protected]>
Signed-off-by: iburylov <[email protected]>
Signed-off-by: iburylov <[email protected]>
Signed-off-by: iburylov <[email protected]>
Signed-off-by: iburylov <[email protected]>
Signed-off-by: iburylov <[email protected]>
Signed-off-by: iburylov <[email protected]>
Signed-off-by: iburylov <[email protected]>
Signed-off-by: iburylov <[email protected]>
Signed-off-by: iburylov <[email protected]>
Signed-off-by: iburylov <[email protected]>
Signed-off-by: iburylov <[email protected]>
…tation (#1943) This second patch finishes the implementation of SYCL_INTEL_accessor_simplification extension. It adds: * `get_host_accessor` to buffer * adds overloads for `get_access` to enable deduction guide * refactored test, as requested in this PR: #1838 * updated deduction guides, based on limitations found via refactored tests
This patch adds the implementation of SYCL_INTEL_accessor_simplification extension.
It adds:
host_accessor
read_only
,write_only
,read_write
,read_constant
tagsnoinit
propertyaccessor
andhost_accessor
to utilize newly added tags and properties for usage simplificationMost use cases for
accessor
has no longer need for specifying template arguments and rely on deduction guides and corresponding tags.sycl::access::target
is now accessible fromsycl::target
andsycl::access::mode
fromsycl::access_mode