Skip to content

[SYCL][E2E] Fix level_zero v2 specifier being stripped too early #18420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 14, 2025
Merged

[SYCL][E2E] Fix level_zero v2 specifier being stripped too early #18420

merged 1 commit into from
May 14, 2025

Conversation

DBDuncan
Copy link
Contributor

@DBDuncan DBDuncan commented May 12, 2025 •
edited
Loading

Fixes #18416

@DBDuncan
[SYCL][E2E] Fix level_zero v2 specifier being stripped too early
234c0a6 
Some tests need to run on the v2 version of the level zero backend. Fix the '_v2' specified being stripped too early.
@DBDuncan DBDuncan requested a review from a team as a code owner May 12, 2025 15:31
@DBDuncan DBDuncan requested a review from slawekptak May 12, 2025 15:31
@DBDuncan DBDuncan temporarily deployed to WindowsCILock May 12, 2025 15:31 — with GitHub Actions Inactive
@DBDuncan
Copy link
Contributor Author

Sorry for the oversight! This should fix the issue.

@DBDuncan DBDuncan temporarily deployed to WindowsCILock May 12, 2025 16:20 — with GitHub Actions Inactive
@DBDuncan DBDuncan temporarily deployed to WindowsCILock May 12, 2025 16:20 — with GitHub Actions Inactive
@npmiller
Copy link
Contributor

@intel/llvm-reviewers-runtime @slawekptak could we get a quick review on this? It's fixing issues in the pre-commit testing.

steffenlarsen
steffenlarsen approved these changes May 14, 2025
View reviewed changes
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's get the Arc CI green again! 🚀

@sommerlukas
Copy link
Contributor

PVC failure is known issue: #18349, merging now.

@sommerlukas sommerlukas merged commit b18e39d into intel:sycl May 14, 2025
35 of 37 checks passed
@sommerlukas sommerlukas mentioned this pull request May 15, 2025
Merged
sarnex pushed a commit that referenced this pull request May 15, 2025
@sommerlukas
Revert "[SYCL][E2E] XFAIL failing DG2 tests" (#18486)
5372698 
Reverts #18445

The root cause for the test failure was fixed in
#18420.

This now leads to unexpectedly passing tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igchor igchor igchor approved these changes

@steffenlarsen steffenlarsen steffenlarsen approved these changes

@slawekptak slawekptak Awaiting requested review from slawekptak slawekptak is a code owner automatically assigned from intel/llvm-reviewers-runtime

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

KernelAndProgram and KernelCompiler test failures on arc A-series
5 participants
@DBDuncan @npmiller @sommerlukas @igchor @steffenlarsen