-
Notifications
You must be signed in to change notification settings - Fork 787
[UR][L0] Refactor IL code handling allowing future extension #18441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Refactor the code to make it easier to add support for different IL formats (besides SPIR-V) in the future. The only functional change is that SPIR-V binaries with invalid magic number are now rejected by returning UR_RESULT_ERROR_INVALID_BINARY from urProgramCreateWithIL.
I believe the CI failure (https://github.com/intel/llvm/actions/runs/14996606351/job/42133884358 ) is unrelated: #18416 |
I don't believe the CI failure is related:
|
ping @intel/unified-runtime-reviewers-level-zero |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly lgtm, just a small nit.
This is a known driver bug. |
@intel/llvm-gatekeepers please merge :) CI failure is unrelated: #18544
|
Refactor the code to make it easier to add support for different IL formats (besides SPIR-V) in the future.
The only functional change is that SPIR-V binaries with invalid magic number are now rejected by returning UR_RESULT_ERROR_INVALID_BINARY from urProgramCreateWithIL.