Skip to content

[UR][CUDA][HIP] Align local memory size env var #18489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
May 20, 2025
Merged

[UR][CUDA][HIP] Align local memory size env var #18489

merged 12 commits into from
May 20, 2025

Conversation

npmiller
Copy link
Contributor

@npmiller npmiller commented May 15, 2025 •
edited
Loading

  • Simplify the env vars check in the CUDA plugin
  • Move env var checks in the device in the HIP plugin
  • Align HIP and CUDA plugins
  • Allow requesting values larger than device capacity, but treat it as device capacity
  • Update test to work on both cuda and hip

@npmiller
[UR][CUDA][HIP] Align local memory size env var
8268a0b 
- Simplify the env vars check in the CUDA plugin
- Move env var checks in the device in the HIP plugin
@npmiller npmiller requested a review from a team as a code owner May 15, 2025 14:42
@npmiller npmiller requested a review from ldrumm May 15, 2025 14:42
@npmiller npmiller temporarily deployed to WindowsCILock May 15, 2025 14:42 — with GitHub Actions Inactive
GeorgeWeb
GeorgeWeb reviewed May 15, 2025
View reviewed changes
@npmiller npmiller temporarily deployed to WindowsCILock May 15, 2025 15:10 — with GitHub Actions Inactive
@npmiller npmiller temporarily deployed to WindowsCILock May 15, 2025 15:10 — with GitHub Actions Inactive
@npmiller npmiller requested a review from a team as a code owner May 16, 2025 09:56
@npmiller npmiller temporarily deployed to WindowsCILock May 16, 2025 09:56 — with GitHub Actions Inactive
@npmiller npmiller temporarily deployed to WindowsCILock May 16, 2025 10:38 — with GitHub Actions Inactive
@npmiller npmiller temporarily deployed to WindowsCILock May 16, 2025 10:38 — with GitHub Actions Inactive
@npmiller npmiller temporarily deployed to WindowsCILock May 16, 2025 11:21 — with GitHub Actions Inactive
@npmiller npmiller temporarily deployed to WindowsCILock May 16, 2025 11:41 — with GitHub Actions Inactive
@npmiller npmiller temporarily deployed to WindowsCILock May 16, 2025 11:41 — with GitHub Actions Inactive
@npmiller npmiller mentioned this pull request May 16, 2025
Merged
@npmiller npmiller temporarily deployed to WindowsCILock May 19, 2025 11:36 — with GitHub Actions Inactive
frasercrmck
frasercrmck approved these changes May 19, 2025
View reviewed changes
@npmiller npmiller temporarily deployed to WindowsCILock May 19, 2025 12:07 — with GitHub Actions Inactive
@npmiller npmiller temporarily deployed to WindowsCILock May 19, 2025 12:14 — with GitHub Actions Inactive
@npmiller npmiller temporarily deployed to WindowsCILock May 19, 2025 12:38 — with GitHub Actions Inactive
@npmiller npmiller temporarily deployed to WindowsCILock May 19, 2025 12:38 — with GitHub Actions Inactive
@npmiller npmiller requested a review from GeorgeWeb May 20, 2025 09:01
aarongreig
aarongreig reviewed May 20, 2025
View reviewed changes
@npmiller
Copy link
Contributor Author

@intel/llvm-gatekeepers this is ready to merge, Jenkins/Precommit failure is an unrelated CI issue

@sarnex sarnex merged commit 343802d into intel:sycl May 20, 2025
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frasercrmck frasercrmck frasercrmck approved these changes

@aarongreig aarongreig aarongreig approved these changes

@ldrumm ldrumm Awaiting requested review from ldrumm ldrumm is a code owner automatically assigned from intel/llvm-reviewers-cuda

@GeorgeWeb GeorgeWeb Awaiting requested review from GeorgeWeb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@npmiller @frasercrmck @GeorgeWeb @aarongreig @sarnex