Skip to content

[SYCL][NFC] Add E2E test for gpu AOT to JIT fallback #18492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 20, 2025

Conversation

KseniyaTikhomirova
Copy link
Contributor

@KseniyaTikhomirova KseniyaTikhomirova commented May 15, 2025

I believe the feature of AOT to JIT fallback was implemented and enabled in this commit 38e588d

commit includes UT for jit fallback for kernel compiled for older platform 38e588d

this fallback works when -fsycl-targets is set for compilation and AOT images contain info about architecture it is built for. In order to build program SYCL RT choose images by compile target (if property is set) and adds spirv (if available) to the image set passed to backend later.

Choice what image to use is done in UR adapter for specific backend. Where it chooses AOT image if available and uses SPIRV as fallback.
While RT part is completely tested by UT, adding small E2E test to verify stack behavior.

@KseniyaTikhomirova KseniyaTikhomirova changed the title [SYCL][NFC] Add test for AOT to JIT fallback [SYCL][NFC] Add E2E test for gpu AOT to JIT fallback May 16, 2025
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
@KseniyaTikhomirova KseniyaTikhomirova marked this pull request as ready for review May 16, 2025 11:19
@KseniyaTikhomirova KseniyaTikhomirova requested a review from a team as a code owner May 16, 2025 11:19
@KseniyaTikhomirova KseniyaTikhomirova marked this pull request as draft May 16, 2025 11:28
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
Copy link
Contributor

@maarquitos14 maarquitos14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a nit.

@maarquitos14
Copy link
Contributor

@jzc can you take a look at this?

Copy link
Contributor

@jzc jzc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KseniyaTikhomirova KseniyaTikhomirova marked this pull request as ready for review May 20, 2025 14:37
@KseniyaTikhomirova
Copy link
Contributor Author

failing check is unrelated, same failure is present in another PRs. @intel/llvm-gatekeepers this PR is ready to be merged.

@sarnex sarnex merged commit 420ac96 into intel:sycl May 20, 2025
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants