[SYCL] Implement sycl_khr_{static, dynamic}_addrspace_cast extensions
#18521
+269
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Aziz <[email protected]>
|
Close/reopen so CI runs with the latest changes, needed to fix build |
dyniols
reviewed
May 20, 2025
Signed-off-by: Michael Aziz <[email protected]>
Signed-off-by: Michael Aziz <[email protected]>
|
Thanks for the review, @dyniols. I've moved the macro definitions as suggested. Please let me know if you'd like me to make any other changes. |
Signed-off-by: Michael Aziz <[email protected]>
|
@intel/llvm-reviewers-runtime, @sergey-semenov, friendly ping. |
steffenlarsen
approved these changes
Jun 2, 2025
| template <access::address_space Space, typename ElementType> | ||
| multi_ptr<ElementType, Space, access::decorated::no> | ||
| dynamic_addrspace_cast(ElementType *ptr) { | ||
| return ext::oneapi::experimental::dynamic_address_cast<Space>(ptr); |
There was a problem hiding this comment.
As an initial solution, I think we can roll with this, but optimally I would like us to flip this dependency eventually. We want this to replace the experimental interfaces, so if we instead have those depend on this extension (which is stable) we can deprecate and remove the experimental ones without too much of a hassle.
Granted, it relies on this not being under the unfinished extension guard.
dm-vodopyanov
changed the title
sycl_khr_{static, dynamic}_addrspace_cast extensionssycl_khr_{static, dynamic}_addrspace_cast extensions
Signed-off-by: Michael Aziz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the extensions defined in KhronosGroup/SYCL-Docs#650.