[SYCL] fix for std::locale::global interfering with allowlist check #18550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Perkins <[email protected]>
cperkinsintel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
cperkinsintel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
cperkinsintel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Signed-off-by: Chris Perkins <[email protected]>
cperkinsintel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
cperkinsintel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
cperkinsintel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
cperkinsintel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
cperkinsintel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
cperkinsintel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Signed-off-by: Chris Perkins <[email protected]>
cperkinsintel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
cperkinsintel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
cperkinsintel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
| @@ -428,6 +428,8 @@ void applyAllowList(std::vector<ur_device_handle_t> &UrDevices, | |||
| uint32_t DeviceVendorIdUInt = | |||
| DeviceImpl.get_info<info::device::vendor_id>(); | |||
| std::stringstream DeviceVendorIdHexStringStream; | |||
| // To avoid commas or other locale-specific modifications, call imbue(). | |||
| DeviceVendorIdHexStringStream.imbue(std::locale::classic()); | |||
There was a problem hiding this comment.
Seems like we do this for a couple other stringstream objects. Could we make a derived class that automatically sets this in the ctor? Might also want to use it in getUint32PropAsOptStr in sycl/source/detail/program_manager/program_manager.cpp.
There was a problem hiding this comment.
I considered making a derived class, but decided against it. The other places ( #18578 ) are few and are in both sycl and syclcompat, and just creating a class doesn't mean people will actually use it.
We've already had a "use custom iostream alternate" phase and "remove custom iostream alternate" phase in the years I've been on this project.
steffenlarsen
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::locale::global()is a very common way for apps to initialize string localization for numeric and monetary values. Unfortunately, it is global.In this very limited fix, we are preventing it from interfering with the allowlist check which uses
std::stringstream. The insertion of commas into numbers for the locale support messes with the expected values.We'll probably have to audit the other uses of std streams to see if they would be similarly vulnerable.