-
Notifications
You must be signed in to change notification settings - Fork 787
[CI] Set a time limit for sycl-cts #18557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Sometimes the job hangs and reaches the 360m limit.
.github/workflows/sycl-nightly.yml
Outdated
@@ -217,6 +217,9 @@ jobs: | |||
run-sycl-cts-linux: | |||
needs: [ubuntu2204_build, build-sycl-cts-linux] | |||
if: ${{ always() && !cancelled() && needs.ubuntu2204_build.outputs.build_conclusion == 'success' }} | |||
# Normally these jobs take less than 10m. But sometimes the job hangs up and | |||
# reaches the 360m limit. Set a lower limit to free up the runner earlier. | |||
timeout-minutes: 60 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
timeout-minutes: 60 | |
timeout-minutes: 30 |
if it's expected to finish under 10.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wish we could do that, but sometimes (like 3 days ago) it took 32min - https://github.com/intel/llvm/actions/runs/15081117059
So 60m probably would be a better limit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sarnex , didn't you have a case recently when a timeout like this was useless?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if i remember correctly that was the LIT_OPTS timeout not working so i added timeout-minutes
if the worst we've seen is 32min can we make it 35min?
It's too close, isn't it? What about 40?:D |
if we hit the 35min timeout id prefer we improve the test or split it or something |
@sarnex @aelovikov-intel I've changed the limit to 35m |
This reverts commit d1beb8e.
This reverts commit d1beb8e.
Sometimes the job hangs and reaches the 360m limit.