Skip to content

[CI] Set a time limit for sycl-cts #18557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 21, 2025

Conversation

KornevNikita
Copy link
Contributor

Sometimes the job hangs and reaches the 360m limit.

Sometimes the job hangs and reaches the 360m limit.
@KornevNikita KornevNikita requested a review from a team as a code owner May 20, 2025 09:09
@@ -217,6 +217,9 @@ jobs:
run-sycl-cts-linux:
needs: [ubuntu2204_build, build-sycl-cts-linux]
if: ${{ always() && !cancelled() && needs.ubuntu2204_build.outputs.build_conclusion == 'success' }}
# Normally these jobs take less than 10m. But sometimes the job hangs up and
# reaches the 360m limit. Set a lower limit to free up the runner earlier.
timeout-minutes: 60
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
timeout-minutes: 60
timeout-minutes: 30

if it's expected to finish under 10.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish we could do that, but sometimes (like 3 days ago) it took 32min - https://github.com/intel/llvm/actions/runs/15081117059
So 60m probably would be a better limit

Copy link
Contributor

@aelovikov-intel aelovikov-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sarnex , didn't you have a case recently when a timeout like this was useless?

Copy link
Contributor

@sarnex sarnex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if i remember correctly that was the LIT_OPTS timeout not working so i added timeout-minutes

if the worst we've seen is 32min can we make it 35min?

@KornevNikita
Copy link
Contributor Author

if i remember correctly that was the LIT_OPTS timeout not working so i added timeout-minutes

if the worst we've seen is 32min can we make it 35min?

It's too close, isn't it? What about 40?:D

@sarnex
Copy link
Contributor

sarnex commented May 20, 2025

if we hit the 35min timeout id prefer we improve the test or split it or something

@KornevNikita
Copy link
Contributor Author

@sarnex @aelovikov-intel I've changed the limit to 35m

@aelovikov-intel aelovikov-intel merged commit d1beb8e into intel:sycl May 21, 2025
3 checks passed
carlewis added a commit to carlewis/llvm that referenced this pull request May 22, 2025
carlewis added a commit to carlewis/llvm that referenced this pull request May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants