Skip to content

[SYCL][Graph] Modified the adapters such that it is valid to call release on... #18619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jun 11, 2025
Merged

[SYCL][Graph] Modified the adapters such that it is valid to call release on... #18619

merged 11 commits into from
Jun 11, 2025

Conversation

konradkusiak97
Copy link
Contributor

Command Buffer, while it is still executing.

@konradkusiak97 konradkusiak97 requested a review from a team as a code owner May 22, 2025 10:50
@konradkusiak97 konradkusiak97 requested a review from EwanC May 22, 2025 10:50
@konradkusiak97 konradkusiak97 force-pushed the konrad/AddSyncToCBRelease branch from cce454f to 8e70e5c Compare May 22, 2025 10:57
EwanC
EwanC reviewed May 22, 2025
View reviewed changes
@konradkusiak97 konradkusiak97 requested a review from a team as a code owner May 26, 2025 13:12
EwanC
EwanC reviewed May 26, 2025
View reviewed changes
@konradkusiak97 konradkusiak97 force-pushed the konrad/AddSyncToCBRelease branch from d97774e to 36dc9cb Compare May 27, 2025 16:07
EwanC
EwanC reviewed Jun 6, 2025
View reviewed changes
@fabiomestre fabiomestre mentioned this pull request Jun 6, 2025
Merged
@konradkusiak97 konradkusiak97 force-pushed the konrad/AddSyncToCBRelease branch from 7e15b46 to 2a70f96 Compare June 10, 2025 11:46
EwanC
EwanC approved these changes Jun 10, 2025
View reviewed changes
@EwanC EwanC mentioned this pull request Jun 10, 2025
Merged
Bensuo added a commit to reble/SYCL-Docs that referenced this pull request Jun 11, 2025
@Bensuo
Add exec graph destruction wording from intel/llvm#18619
b2958d9
@konradkusiak97
Copy link
Contributor Author

To fix the last failure I had to add an event sync on the command buffer release call in the L0 v2 adapter. This was after all the approvals so just FYI @pbalcer @igchor @EwanC @fabiomestre

@konradkusiak97
Copy link
Contributor Author

@intel/llvm-gatekeepers this is ready to merge, thank you

@kbenzie kbenzie merged commit a8c8291 into intel:sycl Jun 11, 2025
33 checks passed
Bensuo added a commit to reble/SYCL-Docs that referenced this pull request Jul 1, 2025
@Bensuo
Add Command-graph class section (#4)
b6f1a15 
- Add command-graph class section to spec draft.
- Align some node section ids to use "khr-graph-*"
- Changes to better align with SYCL spec style:
- Condense overloaded functions into single section where appropriate
- Reorder constraints, effects etc to match current spec style
- Align exception language.
- Add table describing graph states.
- Editorial changes:
- Minor wording changes where I felt we were referring to specific
  implementation behavior.
- Minor rewrites to execution and finalization descriptions for
  increased clarity.
- Add open issues section and note about considering std::filesystem
- Update print_graph description with new behavior
- Add exec graph destruction wording from intel/llvm#18619
- Move unsupported command error to add(), make print graph path const ref
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EwanC EwanC EwanC approved these changes

@fabiomestre fabiomestre fabiomestre approved these changes

@pbalcer pbalcer pbalcer approved these changes

@igchor igchor igchor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@konradkusiak97 @EwanC @fabiomestre @pbalcer @igchor @kbenzie