Skip to content

[SYCL] Make scheduler bypass device selection logic #1862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2020
Merged

[SYCL] Make scheduler bypass device selection logic #1862

merged 1 commit into from
Jun 10, 2020

Conversation

romanovvlad
Copy link
Contributor

No description provided.

@romanovvlad romanovvlad requested a review from a team as a code owner June 10, 2020 10:33
@romanovvlad romanovvlad requested a review from rbegam June 10, 2020 10:33
alexbatashev
alexbatashev reviewed Jun 10, 2020
View reviewed changes
Copy link
Contributor

@alexbatashev alexbatashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this changes anything. AFAIK, sycl looks for libsycl.so/sycl.dll location to get full path to PI libraries. Since scheduler tests are linked statically, such query would fail. As a result, no plugins would be loaded.

@romanovvlad romanovvlad force-pushed the private/vromanov/AdjustTest branch from 083f89c to 7610655 Compare June 10, 2020 12:13
@romanovvlad romanovvlad changed the title [SYCL] Make scheduler test work on any device [SYCL] Make scheduler bypass device selection logic Jun 10, 2020
alexbatashev
alexbatashev approved these changes Jun 10, 2020
View reviewed changes
Copy link
Contributor

@alexbatashev alexbatashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline. My previous comment is related to another problem.

@bader bader merged commit d196ca5 into intel:sycl Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexbatashev alexbatashev alexbatashev approved these changes

@rbegam rbegam Awaiting requested review from rbegam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@romanovvlad @alexbatashev @bader