Skip to content

[SYCL][CUDA] Implement COPY_HOST_PTR #1863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2020

Conversation

Ruyk
Copy link
Contributor

@Ruyk Ruyk commented Jun 10, 2020

When a PI Mem object is created with the PI_MEM_FLAGS_HOST_PTR_COPY,
the CUDA backend now does not use the input pointer for Map/Unmap,
but allocates internal memory for it.

Fixes #1462

@Ruyk Ruyk requested a review from a team as a code owner June 10, 2020 11:22
@Ruyk Ruyk requested a review from smaslov-intel June 10, 2020 11:22
@Ruyk Ruyk force-pushed the copy-in-buffer-create branch from 553099e to 0d10d1d Compare June 10, 2020 11:23
@bader bader added the cuda CUDA back-end label Jun 11, 2020
@bader
Copy link
Contributor

bader commented Jun 11, 2020

@Ruyk, could you resolve merge conflicts, please?

When a PI Mem object is created with the PI_MEM_FLAGS_HOST_PTR_COPY,
the CUDA backend now does not use the input pointer for Map/Unmap,
but allocates internal memory for it.

Fixes intel/llvm#1462

Signed-off-by: Ruyman Reyes <[email protected]>
@Ruyk Ruyk force-pushed the copy-in-buffer-create branch from 0d10d1d to 4e63ddf Compare June 11, 2020 20:21
Copy link
Contributor

@smaslov-intel smaslov-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bader bader merged commit 49b6223 into intel:sycl Jun 19, 2020
@Ruyk Ruyk deleted the copy-in-buffer-create branch June 23, 2020 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cuda CUDA back-end
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CUDA] reduction
3 participants