Follow up fixes after enabling LIT for Level Zero #1876
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix return values in lit.cfg.py * Fix CMake file for get_device_count_by_type tool for the case when local Level Zero lib and headers are provided. Signed-off-by: Artur Gainullin <[email protected]>
Signed-off-by: Artur Gainullin <[email protected]>
FreddyLeaf
pushed a commit
to FreddyLeaf/llvm
that referenced
this pull request
Mar 22, 2023
Despite multiple inheritance static_cast from 'SPIRVEntry *' to 'SPIRV::SPIRVFunction *' should be safe. Replacing static_cast with dynamic_cast would be even safer, but it would add extra runtime overhead. So add ignore this clang-tidy check. Signed-off-by: Sidorov, Dmitry <[email protected]> Original commit: KhronosGroup/SPIRV-LLVM-Translator@676017e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
local Level Zero lib and headers are provided.
Signed-off-by: Artur Gainullin [email protected]