Skip to content

[UR] Update urEnqueueKernelLaunch signature in offload adapter. #18778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 3, 2025
Merged

[UR] Update urEnqueueKernelLaunch signature in offload adapter. #18778

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
631ab7f
[UR] Update urEnqueueKernelLaunch signature in offload adapter.
aarongreig Jun 3, 2025
7bcff29
Update interface loader as well.
aarongreig Jun 3, 2025
e545e2a
One last interface loader fix
aarongreig Jun 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions unified-runtime/source/adapters/offload/enqueue.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,9 @@
UR_APIEXPORT ur_result_t UR_APICALL urEnqueueKernelLaunch(
ur_queue_handle_t hQueue, ur_kernel_handle_t hKernel, uint32_t workDim,
const size_t *pGlobalWorkOffset, const size_t *pGlobalWorkSize,
const size_t *pLocalWorkSize, uint32_t numEventsInWaitList,
const ur_event_handle_t *phEventWaitList, ur_event_handle_t *phEvent) {
const size_t *pLocalWorkSize, uint32_t, const ur_kernel_launch_property_t *,
uint32_t numEventsInWaitList, const ur_event_handle_t *phEventWaitList,
ur_event_handle_t *phEvent) {
// Ignore wait list for now
(void)numEventsInWaitList;
(void)phEventWaitList;
Expand Down
14 changes: 0 additions & 14 deletions unified-runtime/source/adapters/offload/ur_interface_loader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,25 +381,12 @@ UR_DLLEXPORT ur_result_t UR_APICALL urGetEnqueueExpProcAddrTable(
return result;
}

pDdiTable->pfnCooperativeKernelLaunchExp = nullptr;
pDdiTable->pfnTimestampRecordingExp = nullptr;
pDdiTable->pfnNativeCommandExp = nullptr;

return UR_RESULT_SUCCESS;
}

UR_DLLEXPORT ur_result_t UR_APICALL urGetKernelExpProcAddrTable(
ur_api_version_t version, ur_kernel_exp_dditable_t *pDdiTable) {
auto result = validateProcInputs(version, pDdiTable);
if (UR_RESULT_SUCCESS != result) {
return result;
}

pDdiTable->pfnSuggestMaxCooperativeGroupCountExp = nullptr;

return UR_RESULT_SUCCESS;
}

UR_DLLEXPORT ur_result_t UR_APICALL urGetProgramExpProcAddrTable(
ur_api_version_t version, ur_program_exp_dditable_t *pDdiTable) {
auto result = validateProcInputs(version, pDdiTable);
Expand All @@ -424,7 +411,6 @@ UR_DLLEXPORT ur_result_t UR_APICALL urAllAddrTable(ur_api_version_t version,
urGetEnqueueExpProcAddrTable(version, &pDdiTable->EnqueueExp);
urGetEventProcAddrTable(version, &pDdiTable->Event);
urGetKernelProcAddrTable(version, &pDdiTable->Kernel);
urGetKernelExpProcAddrTable(version, &pDdiTable->KernelExp);
urGetMemProcAddrTable(version, &pDdiTable->Mem);
urGetPhysicalMemProcAddrTable(version, &pDdiTable->PhysicalMem);
urGetPlatformProcAddrTable(version, &pDdiTable->Platform);
Expand Down
Loading