[SYCL] Added support for get_backend() API. #1879
Conversation
This API returns the backend associated with a platform. A LIT test has also been added. Signed-off-by: Gail Lyons <[email protected]>
| << plt.get_info<info::platform::name>() << ": " | ||
| << plt.get_info<info::platform::version>(); | ||
| if (!plt.is_host()) { | ||
| std::cout << " BE: " << get_string(plt.get_backend()); |
There was a problem hiding this comment.
If this is related somehow to the SYCL 2020 proposal, the host is also a backend.
There was a problem hiding this comment.
It is not. The L0 PI knows the BE, and it returning it.
| << dev.get_info<info::device::name>() | ||
| << " (" << dev.get_info<info::device::driver_version>() << "): " | ||
| << dev.get_info<info::device::version>() | ||
| << std::endl; |
There was a problem hiding this comment.
This is not really testing anything, but you could try to match testing for "OpenCL" with returning at least the "OpenCL" backend.
There was a problem hiding this comment.
It checks for "opencl", which is the what the test prints for OpenCL backend.
There was a problem hiding this comment.
Refactored the test.
A LIT test has also been added. Incorporated code review comments. Signed-off-by: Gail Lyons <[email protected]>
Signed-off-by: Gail Lyons <[email protected]>
Signed-off-by: Gail Lyons <[email protected]>
| default: | ||
| Out << std::string("unknown"); |
There was a problem hiding this comment.
I'm afraid, this can trigger -Wcovered-switch-default warning on newer compilers as you've already covered all of enum values:
Signed-off-by: Gail Lyons <[email protected]>
|
Windows build failed with error:
Perhaps, adding will fix that. |
Signed-off-by: Gail Lyons <[email protected]>
Signed-off-by: Gail Lyons <[email protected]>
This API returns the backend associated with a platform.
A LIT test has also been added.
Signed-off-by: Gail Lyons [email protected]