Skip to content

Enhance Itanium demangler interface. #1880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2020
Merged

Enhance Itanium demangler interface. #1880

merged 1 commit into from
Jun 17, 2020

Conversation

kbobrovs
Copy link
Contributor

Add new APIs needed to use the demangler for C++ demangling in IR passes.
This is a prerequisite for the upcoming ESIMD LLVM passes.

Signed-off-by: Konstantin S Bobrovsky [email protected]

@kbobrovs kbobrovs requested a review from AlexeySachkov June 12, 2020 19:07
@kbobrovs kbobrovs requested a review from bader as a code owner June 12, 2020 19:07
@kbobrovs kbobrovs mentioned this pull request Jun 12, 2020
Merged
bader
bader reviewed Jun 15, 2020
View reviewed changes
Copy link
Contributor

@bader bader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest committing this directly to llorg repo instead.
It will be pulled into sycl branch from there.
If it's needed in sycl branch urgently, we can cherry-pick it.

@kbobrovs
Copy link
Contributor Author

OK, will do. Reduced the patch to the minimum required.

@kbobrovs
Enhance Itanium demangler interface.
1e05859 
Add new APIs needed to use the demangler for C++ demangling in IR passes.

Signed-off-by: Konstantin S Bobrovsky <[email protected]>
@kbobrovs
Copy link
Contributor Author

Phabricator:
https://reviews.llvm.org/D81905

@bader
Copy link
Contributor

bader commented Jun 16, 2020

Thanks.
Let's hope it will be accepted w/o regression tests and usages inside the project code base.

Please, fix buildbot/sycl-win-x64-pr failure.

@kbobrovs
Copy link
Contributor Author

Please, fix buildbot/sycl-win-x64-pr failure.

The failure is not related to this patch. Just rebuilt, and this time it went fine.

@kbobrovs kbobrovs requested a review from bader June 16, 2020 21:13
@bader bader merged commit db74d92 into intel:sycl Jun 17, 2020
@kbobrovs kbobrovs deleted the esimd-itanium branch July 30, 2020 12:30
FreddyLeaf pushed a commit to FreddyLeaf/llvm that referenced this pull request Mar 22, 2023
@jcranmer-intel @FreddyLeaf
Add support for target extension types to OpenCL type checks. (intel#…
cf0e151 
…1880)

Original commit:
KhronosGroup/SPIRV-LLVM-Translator@b0c6c70
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bader bader bader approved these changes

@AlexeySachkov AlexeySachkov Awaiting requested review from AlexeySachkov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kbobrovs @bader