[SYCL] Copy L0 loader to build dir if path to loader is provided #1884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artur Gainullin <[email protected]>
smaslov-intel
suggested changes
Jun 14, 2020
| file(GLOB L0_LIBRARY_SRC "${L0_LIBRARY}*") | ||
| file(COPY ${L0_LIBRARY_SRC} DESTINATION ${LLVM_LIBRARY_OUTPUT_INTDIR}) | ||
| add_custom_target(l0-loader DEPENDS ${L0_LIBRARY} COMMENT "Copying Level Zero Loader ...") | ||
| if(MSVC) |
There was a problem hiding this comment.
Please remind me why MSVC uses static library?
There was a problem hiding this comment.
It is not a static library, it is an import library for .dll. To use the dll, application should link with this import library. It just has the same .lib extension as static libraries.
There was a problem hiding this comment.
OK, then I am surprised that cmake doesn't have something for it. Linking is always to .lib on Windows and .so on Linux. Even if there is a better way to write this, it shouldn't block this PR.
Signed-off-by: Artur Gainullin <[email protected]>
smaslov-intel
approved these changes
Jun 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Artur Gainullin [email protected]