[SYCL][E2E] Redirect output to /dev/null instead of stdout
#18937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that the compiler output is redirected appropriately to avoid generating an unwanted binary file named "-" by replacing the "-" parameter with the platform‐specific os.devnull.
- Changed the compiler command line argument for the "-o" flag from "-" to f"{os.devnull}".
- Removed the explicit stdout=subprocess.DEVNULL parameter from subprocess.Popen calls.
| @@ -426,10 +425,9 @@ def open_check_file(file_name): | |||
| "c++", | |||
| "-", | |||
| "-o", | |||
| "-", | |||
| f"{os.devnull}", | |||
| ], | |||
| stdin=subprocess.PIPE, | |||
There was a problem hiding this comment.
Redirecting the compiler output consistently by specifying os.devnull helps maintain uniform behavior; ensure that any potential stdout output is handled as intended without the removed stdout=subprocess.DEVNULL parameter.
Suggested change
| stdin=subprocess.PIPE, | |
| stdin=subprocess.PIPE, | |
| stdout=subprocess.DEVNULL, |
Copilot uses AI. Check for mistakes.
Co-authored-by: Copilot <[email protected]>
aelovikov-intel
approved these changes
Jun 11, 2025
uditagarwal97
commented
Jun 11, 2025
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
Jenkins failure is unrelated and an infra issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redirecting output to stdout is not working and LIT is instead creating a binary file named
-.Thus, redirecting output to
/dev/null. os.devnull equals/dev/nullon POSIX and 'null' on Windows