Cast Integer to enumeration type using static_cast for KernelNameType #1895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…defined as templated function object where the template parameter is of enum type (scoped and unscoped). Eg: template <> struct KernelInfo<::dummy_functor_1<(no_namespace_int)0>> to template <> struct KernelInfo<::dummy_functor_1<static_cast<no_namespace_int>(0)>>
…ype_static_cast
srividya-sundaram
requested review from
elizabethandrews,
Fznamznon and
premanandrao
as code owners
|
Error does not seem related to patch. @bader is this a known issue? |
|
Could you please follow these guidelines when writing commit message in the future? https://gist.github.com/robertpainsi/b632364184e70900af4ab688decf6f53 |
|
Tried rebuilding the failed check and got : |
|
Oh strange. I don't think I have write access too but I am able to rebuild. Can you make sure you are signed in? Top right corner will say 'Anonymous' if you are not signed in. Maybe that is issue? |
|
Thanks. I had to authorize bb-sycl to access my github account. |
elizabethandrews
approved these changes
Jun 16, 2020
Fznamznon
approved these changes
Jun 16, 2020
|
This looks like CI issue to me: Please report such errors to the CI team. |
bb-sycl
pushed a commit
that referenced
this pull request
Apr 4, 2023
…on (#1895) Decoration's handling is done alike to other decorations. However, we should preserve the braces so we save the input string after reverse translation. Original commit: KhronosGroup/SPIRV-LLVM-Translator@84e48b0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For specializations of KernelInfo for kernel function types, cast Integer to Enumeration type using static_cast.
Eg:
template <> struct KernelInfo<::dummy_functor_1<(no_namespace_int)0>>totemplate <> struct KernelInfo<::dummy_functor_1<static_cast<no_namespace_int>(0)>>Issue# : #1784