Skip to content

[SYCL][LowerWGScope] Fix getSizeTTy to use pointer size in global address space #19011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 17, 2025

Conversation

wenju-he
Copy link
Contributor

In LowerWGScope pass, getSizeTTy is used as return type of local id functions. We should use pointer size in global address space, to ensure size_t is sufficient to represent the global range.

…ress space

In LowerWGScope pass, getSizeTTy is used as return type of local id
functions. We should use pointer size in global address space, to
ensure size_t is sufficient to represent the global range.
@wenju-he wenju-he requested a review from a team as a code owner June 17, 2025 08:38
@bader
Copy link
Contributor

bader commented Jun 17, 2025

@intel/dpcpp-devops-reviewers, the run_prebuilt_e2e_tests (Intel Arc A-Series Graphics, ["Linux", "arc"], -u 1001 --device=/dev/dri ... / Intel Arc A-Series Graphics results don't make sense to me. The results are clean on all other machines, so I think this is some environment issue. Am I right?

Total Discovered Tests: 2405
  Unsupported      :  575 (23.91%)
  Passed           : 1054 (43.83%)
  Expectedly Failed:    2 (0.08%)
  Timed Out        :   11 (0.46%)
  Failed           :  763 (31.73%)

@sarnex
Copy link
Contributor

sarnex commented Jun 17, 2025

Seems like it, I restarted testing to confirm. We just made a change to CI that should make this much more unlikely.

@bader
Copy link
Contributor

bader commented Jun 17, 2025

Seems like it, I restarted testing to confirm. We just made a change to CI that should make this much more unlikely.

Passed. @sarnex, thank you!

@bader bader merged commit e2bd09d into intel:sycl Jun 17, 2025
38 of 39 checks passed
@bader
Copy link
Contributor

bader commented Jun 17, 2025

@intel/dpcpp-devops-reviewers, another environment issue in the post-commit. SYCL end-to-end test runner can't find a device. Is there anything I can do about it?

[0/1] Running SYCL End-to-End tests
lit.py: /__w/llvm/llvm/llvm/sycl/test-e2e/lit.cfg.py:625: note: Targeted devices: level_zero:gpu
lit.py: /__w/llvm/llvm/llvm/sycl/test-e2e/lit.cfg.py:836: note: Found pre-installed AOT device compiler ocloc
lit.py: /__w/llvm/llvm/llvm/sycl/test-e2e/lit.cfg.py:836: note: Found pre-installed AOT device compiler opencl-aot
lit.py: /__w/llvm/llvm/llvm/sycl/test-e2e/lit.cfg.py:941: note: Using installed device config file
lit.py: /__w/llvm/llvm/llvm/sycl/test-e2e/lit.cfg.py:1005: error: Cannot detect device aspect for level_zero:gpu
stdout:

Platforms: 0
default_selector()      : No device of requested type available.
accelerator_selector()  : No device of requested type available.
cpu_selector()          : No device of requested type available.
gpu_selector()          : No device of requested type available.
custom_selector(gpu)    : No device of requested type available.
custom_selector(cpu)    : No device of requested type available.
custom_selector(acc)    : No device of requested type available.

stderr:
INFO: Output filtered by ONEAPI_DEVICE_SELECTOR environment variable, which is set to level_zero:gpu.
To see device ids, use the --ignore-device-selectors CLI option.

<LOADER>[INFO]: The adapter 'libur_adapter_level_zero_v2.so.0' is skipped because UR_LOADER_USE_LEVEL_ZERO_V2 or SYCL_UR_USE_LEVEL_ZERO_V2 is not set.
<LOADER>[INFO]: loaded adapter 0x0x5ca6f5c74290 (libur_adapter_level_zero.so.0) from /__w/llvm/llvm/toolchain/lib/libur_adapter_level_zero.so.0

@sarnex
Copy link
Contributor

sarnex commented Jun 17, 2025

No the runner needs a reboot I'll do it now

@sarnex
Copy link
Contributor

sarnex commented Jun 17, 2025

runner + job restarted and passed this time

@bader
Copy link
Contributor

bader commented Jun 17, 2025

runner + job restarted and passed this time

Thanks!

@wenju-he wenju-he deleted the LowerWGScope-getSizeTTy branch June 18, 2025 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants