Skip to content

[SYCL] [Graph] Refactor graph headers #19045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Jun 25, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
7d0b070
Change passing Graph by const &
konradkusiak97 Jun 19, 2025
d758b0f
extract graph.hpp into split headers
konradkusiak97 Jun 19, 2025
23efa83
Splitted the code from graph.hpp into seperate files
konradkusiak97 Jun 19, 2025
a13fe83
Merged definition and declaration of print_graph
konradkusiak97 Jun 19, 2025
d50f522
Copied graph impl files into new files in graph/
konradkusiak97 Jun 19, 2025
9c30de8
Splitted the code from graph_impl.hpp(.cpp) into seperate files
konradkusiak97 Jun 19, 2025
e158852
Renamed files
konradkusiak97 Jun 19, 2025
726de46
Removed files
konradkusiak97 Jun 19, 2025
c57a810
Fixes to compile
konradkusiak97 Jun 19, 2025
c9d6bb8
Further splitted command_graph into modifiable and executable
konradkusiak97 Jun 19, 2025
55e7049
Dumb windows
konradkusiak97 Jun 19, 2025
09470c9
Copied to new names to preserve history
konradkusiak97 Jun 23, 2025
bb592bc
Removed graph_* files
konradkusiak97 Jun 23, 2025
2bec6bb
Removed unnecesary includes
konradkusiak97 Jun 23, 2025
d1d4905
Modified CODEOWNERS for new graph files
konradkusiak97 Jun 23, 2025
ccf04bf
Added proper include to graph_properties after moving the helper func…
konradkusiak97 Jun 23, 2025
58ce40e
Fixed includes and hashes
konradkusiak97 Jun 23, 2025
498bf9e
Fixed dependencies file
konradkusiak97 Jun 23, 2025
124b117
Changed names of public files in graph
konradkusiak97 Jun 23, 2025
e36f1d9
Changed naming in includes and deleted unnecesary files
konradkusiak97 Jun 23, 2025
88ec242
Removed white spaces and fixed formating
konradkusiak97 Jun 24, 2025
16cedbe
Moved graph_state to common.hpp
konradkusiak97 Jun 24, 2025
dc48d70
Patched changes from c73c9d0 commit
konradkusiak97 Jun 25, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -163,10 +163,8 @@ libdevice/nativecpu* @intel/dpcpp-nativecpu-reviewers

# SYCL-Graphs extensions
sycl/include/sycl/ext/oneapi/experimental/graph.hpp @intel/sycl-graphs-reviewers
sycl/source/detail/graph_impl.cpp @intel/sycl-graphs-reviewers
sycl/source/detail/graph_impl.hpp @intel/sycl-graphs-reviewers
sycl/source/detail/graph_memory_pool.hpp @intel/sycl-graphs-reviewers
sycl/source/detail/graph_memory_pool.cpp @intel/sycl-graphs-reviewers
sycl/include/sycl/ext/oneapi/experimental/graph @intel/sycl-graphs-reviewers
sycl/source/detail/graph @intel/sycl-graphs-reviewers
sycl/unittests/Extensions/CommandGraph/ @intel/sycl-graphs-reviewers
sycl/test-e2e/Graph @intel/sycl-graphs-reviewers
sycl/doc/design/CommandGraph.md @intel/sycl-graphs-reviewers
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@

#include <sycl/detail/property_helper.hpp> // for DataLessPropKind
#include <sycl/properties/property_traits.hpp> // for is_property_of
#include <sycl/property_list.hpp> // for property_list

#include <type_traits> // for true_type

Expand All @@ -36,10 +37,30 @@ class node;
namespace property::node {
class depends_on;
} // namespace property::node
// Graph property trait specializations.

enum class graph_state;
template <graph_state State> class command_graph;

namespace detail {
inline void checkGraphPropertiesAndThrow(const property_list &Properties) {
auto CheckDataLessProperties = [](int PropertyKind) {
#define __SYCL_DATA_LESS_PROP(NS_QUALIFIER, PROP_NAME, ENUM_VAL) \
case NS_QUALIFIER::PROP_NAME::getKind(): \
return true;
#define __SYCL_MANUALLY_DEFINED_PROP(NS_QUALIFIER, PROP_NAME)
switch (PropertyKind) {
#include <sycl/ext/oneapi/experimental/detail/properties/graph_properties.def>

default:
return false;
}
};
// No properties with data for graph now.
auto NoAllowedPropertiesCheck = [](int) { return false; };
sycl::detail::PropertyValidator::checkPropsAndThrow(
Properties, CheckDataLessProperties, NoAllowedPropertiesCheck);
}
} // namespace detail
} // namespace experimental
} // namespace oneapi
} // namespace ext
Expand Down
Loading