Skip to content

Add diagnostic on invalid device list #1906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2020

Conversation

romanovvlad
Copy link
Contributor

No description provided.

@romanovvlad romanovvlad requested a review from a team as a code owner June 16, 2020 17:08
@romanovvlad romanovvlad requested a review from vladimirlaz June 16, 2020 17:08
Copy link
Contributor

@AGindinson AGindinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should a regression test be supplied?

@romanovvlad
Copy link
Contributor Author

Should a regression test be supplied?

Ok, will do it, just was hoping that such minor change would be able to sneak without the test :)

@romanovvlad romanovvlad force-pushed the private/vromanov/FixComplains branch from 3cde8fd to b64cd30 Compare June 17, 2020 14:35
@romanovvlad
Copy link
Contributor Author

Should a regression test be supplied?

Ok, will do it, just was hoping that such minor change would be able to sneak without the test :)

Should a regression test be supplied?

Added a test.

@bader bader merged commit cce700d into intel:sycl Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants