[SYCL] Fix unloading of shared images on Windows #19074
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
|
@cperkinsintel & @nrspruit - I think we need to reopen this can of worms. Though it is not immediately obvious, this is actually affecting sycl/test-e2e/syclcompat/kernel/kernel_win.cpp and sycl/unittests/Extensions/RootGroup.cpp. They started failing for the changes in #18949 and I narrowed the failures down to the cause described in this PR. |
After intel#17869, Windows will not unload images during the runtime of the program. However, this means that shared libraries that are dynamically loaded and unloaded will leave dangling pointers to their images. If somehow these images get picked up, e.g. if another library is loaded with overlapping symbols, the runtime may try to dereference the dangling device image pointers. This commit reenables Windows unloading with the caveat that once the global handler is dead the runtime assumes that shutdown has begun. Signed-off-by: Larsen, Steffen <[email protected]>
steffenlarsen
force-pushed
the
steffen/reenable_shutdown_cleanup_windows
branch
from
04ab3fb to
c79dd80
Compare
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
pushed a commit
that referenced
this pull request
Jun 23, 2025
Changes the `MockDeviceImage` and `MockDeviceImageArray` to static variables so that they're not created in each test case. Relates to #19068 and #19074. Fixes #18892. Signed-off-by: Michael Aziz <[email protected]>
|
Talking to @cperkinsintel offline, it turns out this is never called on Windows, so this will have no effect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #17869, Windows will not unload images during the runtime of the program. However, this means that shared libraries that are dynamically loaded and unloaded will leave dangling pointers to their images. If somehow these images get picked up, e.g. if another library is loaded with overlapping symbols, the runtime may try to dereference the dangling device image pointers. This commit reenables Windows unloading with the caveat that once the global handler is dead the runtime assumes that shutdown has begun.