[SYCL] Make ur::getAdapter return raw adapter pointer instead of shared_ptr
#19102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
uditagarwal97
commented
Jun 23, 2025
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
uditagarwal97
commented
Jun 23, 2025
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
Followup PR to pass adapter by ref instead of pointer: #19105 |
vinser52
requested changes
Jun 24, 2025
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
slawekptak
reviewed
Jun 25, 2025
| @@ -34,7 +34,7 @@ namespace detail { | |||
| class context_impl; | |||
| class event_impl; | |||
| class Adapter; | |||
| using AdapterPtr = std::shared_ptr<Adapter>; | |||
| using AdapterPtr = Adapter *; | |||
There was a problem hiding this comment.
We have the AdapterPtr type still defined, so is there a reason to mix the use of AdapterPtr and Adapter *? Would it be possible to unify to one or the other? I think that typically, the *Ptr types are shared_ptrs in SYCL code, so maybe just remove this type and use a raw pointer everywhere?
There was a problem hiding this comment.
I have a follow-up PR (#19105) where I removed AdapterPtr completely and returned Adapter reference instead of a pointer. Removing AdapterPtr is a big, mostly-NFC change so I created a seperate PR.
| std::weak_ptr<Adapter> AdapterWeakPtr; | ||
| KernelBuildResult(const AdapterPtr &Adapter) : AdapterWeakPtr(Adapter) { | ||
| AdapterPtr adapter; | ||
| KernelBuildResult(const AdapterPtr &_adapter) : adapter(_adapter) { |
There was a problem hiding this comment.
Maybe just pass a raw pointer by value instead of reference?
There was a problem hiding this comment.
In the subsequent PR, I'll be replacing Adapter* with Adapter reference instead so, this change is aligned with it.
vinser52
approved these changes
Jun 25, 2025
slawekptak
approved these changes
Jun 25, 2025
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@intel/unified-runtime-reviewers ping |
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
ur::getAdapterreturns a shared pointer to the adapter. However, that's unnecessary.This PR makes
ur::getAdapterreturn a raw ptr instead and let global handler manage lifetime of the adapter object.