Skip to content

[SYCL] Fix program::set_spec_constant - add state check. #1911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2020

Conversation

kbobrovs
Copy link
Contributor

Throw spec_const_error on set_spec_constant attempt if the program
is already compiled or linked.

Signed-off-by: Konstantin S Bobrovsky [email protected]

@kbobrovs kbobrovs requested a review from a team as a code owner June 17, 2020 00:53
@kbobrovs kbobrovs requested a review from vladimirlaz June 17, 2020 00:53
@vladimirlaz
Copy link
Contributor

Looks like valid failure to be fixed.

Throw spec_const_error on set_spec_constant attempt if the program
is already compiled or linked.

Signed-off-by: Konstantin S Bobrovsky <[email protected]>
@kbobrovs
Copy link
Contributor Author

This is ACC failure. Spec constants are actually not supported there - removed ACC from the test case.

@kbobrovs kbobrovs requested a review from vladimirlaz June 18, 2020 17:20
@kbobrovs kbobrovs merged commit e94d82f into intel:sycl Jun 18, 2020
@kbobrovs kbobrovs deleted the sc-throw branch July 30, 2020 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants