Backport packaging improvements to 6.2 #19152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For all external dependencies, we should try using the system installed one first and only download the repo if we can't find it. Apply that for vc-intrinics first, I manually tested this with both static and shared library builds. --------- Signed-off-by: Sarnie, Nick <[email protected]>
Signed-off-by: Sarnie, Nick <[email protected]>
Signed-off-by: Sarnie, Nick <[email protected]>
Signed-off-by: Sarnie, Nick <[email protected]>
…se (#17922) After this change, you can use `-DUR_COMPUTE_RUNTIME_FETCH_REPO=OFF -DUR_COMPUTE_RUNTIME_REPO=<path_to_l0_repo>` to disable fetching the compute runtime repo for L0 include headers and ask cmake to use a local compute runtime repo instead.
I'm trying to make dpcpp more friendly to packaging by Linux distros, and we should be using system-installed dependencies by default. Find the system-installed compute-runtime headers and use them if they exist instead of downloading the upstream repo. Also fix an include that doesn't work with system headers. Signed-off-by: Sarnie, Nick <[email protected]>
Signed-off-by: Sarnie, Nick <[email protected]>
Two problems: 1) The option was renamed to `--gcc-install-dir` 2) We forgot to pass the flag for the IMF build. --------- Signed-off-by: Sarnie, Nick <[email protected]>
Signed-off-by: Sarnie, Nick <[email protected]>
Fixes issue reported [here](#18599 (comment)). Signed-off-by: Sarnie, Nick <[email protected]>
|
Precommit CI is known broken, and merging this as it should be NFC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want the next release to have these packaging improvements.
Nightly run here.