[SYCL] Align linkage in windows build. #1929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-kanaev
force-pushed
the
private/s-kanaev/fix-4
branch
2 times, most recently
from
476a6c3 to
cc7ec98
Compare
s-kanaev
force-pushed
the
private/s-kanaev/fix-4
branch
from
cc7ec98 to
e1518f6
Compare
s-kanaev
commented
Jun 19, 2020
| context make_context(pi_native_handle NativeHandle); | ||
| program make_program(const context &Context, pi_native_handle NativeHandle); | ||
| queue make_queue(const context &Context, pi_native_handle InteropHandle); | ||
| __SYCL_EXPORT platform make_platform(pi_native_handle NativeHandle); |
There was a problem hiding this comment.
This fixes compilation failure for windows, which resulted in error C2375: 'cl::sycl::opencl::make_platform': redefinition; different linkage.
v-klochkov
reviewed
Jun 19, 2020
…/backend/opencl.hpp Signed-off-by: Sergey Kanaev <[email protected]>
s-kanaev
force-pushed
the
private/s-kanaev/fix-4
branch
from
e1518f6 to
6685d9f
Compare
s-kanaev
changed the title
smaslov-intel
approved these changes
Jun 22, 2020
v-klochkov
approved these changes
Jun 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes compilation failure for windows, which resulted in error C2375: 'cl::sycl::opencl::make_platform': redefinition; different linkage.