[SYCL] Ensure Int-header prints CVR qualifiers for class template params #1932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The integration header code seems to skip CVR qualifiers in at least this one branch, so it makes the type unusable in the host build. This patch ensures that the qualifiers get printed.
erichkeane
requested review from
elizabethandrews,
Fznamznon and
premanandrao
as code owners
Fznamznon
approved these changes
Jun 19, 2020
premanandrao
approved these changes
Jun 19, 2020
zahiraam
approved these changes
Jun 19, 2020
elizabethandrews
approved these changes
Jun 19, 2020
|
I am amazed by the code which is possible to be written in SYCL... :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The integration header code seems to skip CVR qualifiers in at least
this one branch, so it makes the type unusable in the host build. This
patch ensures that the qualifiers get printed.