[SYCL] Add global namespace specifier for Enum Values #1939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch is a follow up to commit e7020a1. The prior commit appends required scope resolution operator when kernel name is templated with enum type but not enum value. This patch adds the missing scope resolution operator when handling enum values. Signed-off-by: Elizabeth Andrews <[email protected]>
elizabethandrews
requested review from
Fznamznon and
premanandrao
as code owners
elizabethandrews
changed the title
Signed-off-by: Elizabeth Andrews <[email protected]>
erichkeane
approved these changes
Jun 19, 2020
zahiraam
approved these changes
Jun 20, 2020
Fznamznon
approved these changes
Jun 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is a follow up to commit e7020a1. The prior commit
appends required scope resolution operator when kernel name is
templated with enum type but not enum value. This patch adds the
missing scope resolution operator when handling enum values.
Signed-off-by: Elizabeth Andrews [email protected]