[SYCL][CUDA] Cleanup of profiling events #1956
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additional CUDA events created for profiling are now released upon destruction of the PI Event. Signed-off-by: Ruyman Reyes <[email protected]>
bader
approved these changes
Jun 23, 2020
|
@smaslov-intel, @intel/llvm-reviewers-runtime, ping. |
s-kanaev
approved these changes
Jun 24, 2020
There was a problem hiding this comment.
LGTM, but I believe @smaslov-intel should look a this also.
smaslov-intel
approved these changes
Jul 6, 2020
bb-sycl
pushed a commit
that referenced
this pull request
Apr 18, 2023
It might be set as null in case if a function pointer is passed as auto template parameter. The patch also adds a test for a 'good' DW_TAG_template_value_parameter value for function pointers, just because this case was untested. Signed-off-by: Sidorov, Dmitry <[email protected]> Original commit: KhronosGroup/SPIRV-LLVM-Translator@093814a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional CUDA events created for profiling are now
released upon destruction of the PI Event.
Signed-off-by: Ruyman Reyes [email protected]