[SYCL] Added arbitrary integer SPIR-V spec as an extension #1957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrodman
approved these changes
Jun 26, 2020
bader
added
the
spec extension
againull
pushed a commit
to againull/llvm
that referenced
this pull request
May 4, 2023
This is a massive change, which consists of the following pieces that are not so easily seperable (why this is a large, single commit instead of many smaller ones):
Use typed pointer types in the external interface of the scavenger.
Use target extension types in lieu of DeferredType to represent types not yet known. These types are now target("typevar", N), where N is some integer.
Use TypedPointerType in lieu of DeducedType. This makes multi-level pointer types simpler to use.
Replace std::pair<unsigned, DeducedType> with a more generalized TypeRule class, which simplifies some of the rules for the typing procedure.
Make computePointerElementType and correctUseTypes both rely on the same list of type rules, removing duplication.
Add support for vectors of pointers, arrays of pointers, and function pointers in the type scavenger.
Allow global variables to have scavenged types.
Allow return types to not be i8*.
Add more documentation of the type scavenger process.
More tests!
Miscellaneous type rule fixes.
Overall, the logic of the type scavenger largely remains unchanged (albeit with increased functionality), but the way that logic is expressed has changed very significantly, and the easier functionality for handling a few cases causes shifting of expected bitcast placements in existing tests.
Original commit:
KhronosGroup/SPIRV-LLVM-Translator@cb6de04
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a new extension to enable SPIR-V to use arbitrary precision integers, with a default maximum bitwidth (with this extension) up to 32 bits, but implementers are allowed to go up to any arbitrary bitwidth.