[SYCL-PTX] Refactor of libclc sources in preparation of math builtins implementation #1958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bader
reviewed
Jun 23, 2020
Naghasan
force-pushed
the
victor/spirv-ptx-math-refactoring
branch
from
96cec00 to
a1b98de
Compare
… category implementation The patch moves some include files from libs to include so they can be shared with libspirv side. Refactor the ptx-nvidiacl side as well and move the following builtins in their own file to avoid symbol redefinition: - acosh - asinh - atanh - cosh - erfc Signed-off-by: Victor Lomuller <[email protected]> Co-authored-by: David Wood <[email protected]>
Naghasan
force-pushed
the
victor/spirv-ptx-math-refactoring
branch
from
a1b98de to
f6052be
Compare
bader
approved these changes
Jun 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch moves some header files from libs to include so they can be shared with the libspirv side.
Refactor the ptx-nvidiacl side as well and move the following builtins in their own file to avoid symbol redefinition:
Signed-off-by: Victor Lomuller [email protected]
Co-authored-by: David Wood [email protected]