Skip to content

[SYCL][CUDA] libclc Image Support for CUDA #1971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 7, 2020

Conversation

nyalloc
Copy link
Contributor

@nyalloc nyalloc commented Jun 24, 2020

Provides an implementation of image / sampling builtins required for CUDA backend image support.

Sampled image builtins are implemented with half support. Will not generate the half builtins until cl_khr_fp16 is set as supported, which requires #2003 to be merged.

@nyalloc nyalloc requested a review from bader as a code owner June 24, 2020 10:51
@bader bader added the cuda CUDA back-end label Jun 24, 2020
@nyalloc nyalloc changed the title [SYCL][CUDA][WIP] Updated libclc/ptx-nvidiacl/libspirv image support [SYCL][CUDA] Updated libclc/ptx-nvidiacl/libspirv image support Jun 24, 2020
@nyalloc nyalloc changed the title [SYCL][CUDA] Updated libclc/ptx-nvidiacl/libspirv image support [SYCL][CUDA][WIP] Updated libclc/ptx-nvidiacl/libspirv image support Jun 25, 2020
@nyalloc nyalloc changed the title [SYCL][CUDA][WIP] Updated libclc/ptx-nvidiacl/libspirv image support [SYCL][CUDA][WIP] Add image support for the CUDA target Jun 25, 2020
@nyalloc nyalloc changed the title [SYCL][CUDA][WIP] Add image support for the CUDA target [SYCL][CUDA][WIP] Add image support for the CUDA target in libclc Jun 26, 2020
@nyalloc nyalloc changed the title [SYCL][CUDA][WIP] Add image support for the CUDA target in libclc [SYCL][CUDA][WIP] libclc Image Support for CUDA Jun 26, 2020
@nyalloc nyalloc force-pushed the stuart/libclc/images branch from 198d6e3 to 645ad86 Compare June 26, 2020 14:21
@nyalloc nyalloc force-pushed the stuart/libclc/images branch from 645ad86 to a46013a Compare June 29, 2020 18:06
@nyalloc nyalloc changed the title [SYCL][CUDA][WIP] libclc Image Support for CUDA [SYCL][CUDA] libclc Image Support for CUDA Jun 29, 2020
bader
bader previously approved these changes Jul 6, 2020
@bader
Copy link
Contributor

bader commented Jul 6, 2020

@StuartDAdams, could you take a look at build failure, please?

Intrinsic has incorrect argument type!
void (%opencl.image1d_wo_t addrspace(1)*, i32, i32, i32, i32, i32)* @llvm.nvvm.sust.b.1d.v4i32.clamp
in function _Z18__spirv_ImageWriteI14ocl_image1d_woiDv4_fEvT_T0_T1_

@nyalloc
Copy link
Contributor Author

nyalloc commented Jul 7, 2020

@StuartDAdams, could you take a look at build failure, please?

Intrinsic has incorrect argument type!
void (%opencl.image1d_wo_t addrspace(1)*, i32, i32, i32, i32, i32)* @llvm.nvvm.sust.b.1d.v4i32.clamp
in function _Z18__spirv_ImageWriteI14ocl_image1d_woiDv4_fEvT_T0_T1_

I've not been able to reproduce this locally yet. The branch has since been updated so if it fails to build on the CI again with this message I'll make sure to look into it as soon as possible.

@bader bader merged commit 4629ad0 into intel:sycl Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cuda CUDA back-end
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants