[SYCL][NFC] Update sub_group test for native subgroups mode #1973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wuw2
changed the title
alexbatashev
previously approved these changes
Jun 24, 2020
There was a problem hiding this comment.
LGTM. @wuw2 please update PR description with some rationale. What changes make the updated version of test possible?
wuw2
force-pushed
the
cpu_native_subgroup_test
branch
from
ef0f5ea to
d1a30e9
Compare
Updated |
|
I'd like @Pennycook to sign off on this. |
Pennycook
requested changes
Jun 24, 2020
vladimirlaz
suggested changes
Jun 25, 2020
Previously, the execution mode of CPU subgroup is emulation mode, which means a subgroup == a workgroup. Since OCL CPU RT has enabled native subgroups by default, we need to update these sycl subgroup tests.
wuw2
force-pushed
the
cpu_native_subgroup_test
branch
from
d1a30e9 to
8a39ba3
Compare
Pennycook
approved these changes
Jun 25, 2020
vladimirlaz
approved these changes
Jun 26, 2020
againull
pushed a commit
to againull/llvm
that referenced
this pull request
May 4, 2023
This instruction is generated for DWARF `DISPFlagMainSubprogram` flag of function as well as for `spir_kernel` functions. Spec: https://github.com/KhronosGroup/SPIRV-Registry/blob/main/nonsemantic/NonSemantic.Shader.DebugInfo.100.asciidoc#DebugEntryPoint Original commit: KhronosGroup/SPIRV-LLVM-Translator@8565381
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These sycl subgroup tests assumed cpu subgroup executes in emulation mode, which means a subgroup == a workgroup. Since OCL CPU RT has enabled native subgroups by default, we need to update these tests