[SYCL] Fix unreleased events returned by queue USM API #1979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The events were created with the interoperability constructor that performed an unneeeded retain. Signed-off-by: Sergey Semenov <[email protected]>
s-kanaev
approved these changes
Jun 24, 2020
| @@ -87,6 +95,7 @@ TEST(QueueWaitTest, USMEventClear) { | |||
| Q.memset(HostAlloc, 42, 1); | |||
| Q.wait(); | |||
| ASSERT_EQ(TestContext->NEventsWaitedFor, 1); | |||
| ASSERT_EQ(TestContext->EventReferenceCount, 0); | |||
| Q.wait(); | |||
| ASSERT_EQ(TestContext->NEventsWaitedFor, 1); | |||
There was a problem hiding this comment.
The event reference count should be nil after the second call to wait() also, isn't it?
There was a problem hiding this comment.
Right, I just don't think it's worth checking once it already hits 0.
There was a problem hiding this comment.
Anyway it would be nice to have it stressed in the test.
|
The queue_parallel_for_generic failure should be fixed by #1976, restarted for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The events were created with the interoperability constructor that
performed an unneeded retain.
Signed-off-by: Sergey Semenov [email protected]