-
Notifications
You must be signed in to change notification settings - Fork 787
[SYCL] Add missing builtins for vec<X, 1> #1984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Please add a trivial LIT test or extend some existing test. |
@alexbatashev ping |
Signed-off-by: Alexander Batashev <[email protected]>
Signed-off-by: Alexander Batashev <[email protected]>
Our current tests are not really scalable, and covering >500 builtins in one PR looks to much for me. Is it ok if I add a simple smoke test for now, and do a followup with better testing? |
I think adding a simple smoke test is enough for LIT testing, we are not aiming to cover 100% of use cases with LIT tests. |
Then I’ll look into why CTS didn’t catch missing builtins. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test needs minor fix in the compilation RUN line.
Signed-off-by: Alexander Batashev <[email protected]>
Signed-off-by: Alexander Batashev <[email protected]>
@v-klochkov I found even more missing builtins, and I believe some are still missing. I'll do a followup on adding the rest of them once proper testing is in place. |
On host using builtins with
vec<X, 1>
types causes linkage errors. Add missing overloads.