Skip to content

[SYCL][CUDA] PI API Sampler Support for CUDA #1993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 7, 2020

Conversation

nyalloc
Copy link
Contributor

@nyalloc nyalloc commented Jun 26, 2020

This PR introduces an implementation of the pi_sampler API for the PI CUDA backend.

It also introduces piextKernelSetArgSampler function which has been defined in the CUDA, OpenCL and Level0 backends.

Testing is provided by #1961 and #1969.

@nyalloc nyalloc requested a review from a team as a code owner June 26, 2020 11:10
@nyalloc nyalloc requested a review from smaslov-intel June 26, 2020 11:10
@nyalloc nyalloc changed the title [SYCL][CUDA] Implemented CUDA PI API sampler [SYCL][CUDA] PI API Sampler Support for CUDA Jun 26, 2020
@nyalloc nyalloc force-pushed the stuart/pi_sampler_impl branch from 87d718d to 44893a8 Compare June 26, 2020 13:42
@nyalloc nyalloc requested a review from a team as a code owner June 26, 2020 13:42
@bader bader added the cuda CUDA back-end label Jun 29, 2020
@bader
Copy link
Contributor

bader commented Jul 3, 2020

@intel/llvm-reviewers-cuda, @smaslov-intel, @intel/llvm-reviewers-runtime, ping.

@StuartDAdams, could you resolve merge conflicts, please?

Copy link
Contributor

@smaslov-intel smaslov-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just asking to document the added PI interface

Added piextKernelSetArgSampler PI API function
@nyalloc nyalloc force-pushed the stuart/pi_sampler_impl branch from 44893a8 to 81ec4f7 Compare July 6, 2020 14:32
@bader bader requested a review from smaslov-intel July 6, 2020 14:38
@bader bader merged commit 1e7185a into intel:sycl Jul 7, 2020
kchusha pushed a commit to kchusha/llvm that referenced this pull request May 10, 2023
Max length of SPIRV instruction is 65535 words by specification.
DebugSourceContinued helps to overcome the limitation and specify full source code text by continuing the string from the previous DebugSource(Continued)instruction.

Spec:
https://github.com/KhronosGroup/SPIRV-Registry/blob/main/nonsemantic/NonSemantic.Shader.DebugInfo.100.asciidoc#DebugSourceContinued

Original commit:
KhronosGroup/SPIRV-LLVM-Translator@aabcaf8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cuda CUDA back-end
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants