Skip to content

Add workaround for MSVC++ 2017 bug to ItaniumDemangle.h. #2021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2020
Merged

Add workaround for MSVC++ 2017 bug to ItaniumDemangle.h. #2021

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions llvm/include/llvm/Demangle/ItaniumDemangle.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,6 +445,14 @@ class EnableIfAttr : public Node {
}
};

#ifdef _MSC_VER
// Workaround for MSVC++ bug (Version 2017, 15.8.9) - w/o this forward
// declaration, the friend declaration in ObjCProtoName below has no effect
// and leads to compilation error when ObjCProtoName::Protocol private field
// is accessed in PointerType::printLeft.
class PointerType;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, amend https://reviews.llvm.org/D81905 with this workaround.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, will do.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the record - done.

#endif // _MSC_VER

class ObjCProtoName : public Node {
const Node *Ty;
StringView Protocol;
Expand Down