[SYCL][CUDA] Fix:Events not calling start for some commands #2028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanovvlad
reviewed
Jul 8, 2020
|
@przemektmalon, could you resolve merge conflicts, please? |
This commit ensures that `piEnqueueMemBufferCopy`, `piEnqueueMemBufferFill` and other commands call both `start()` and `record()` correctly if events are requested from them. An assertion is added to ensure this always happens from now on. Some command types are also changed to reflect the actual command, for example `cuda_piEnqueueMemBufferReadRect` not using the `RECT` version of the buffer read command type. Some event parameter names are also changed to provide naming consistency throughout the code. Signed-off-by: Przemek Malon <[email protected]>
przemektmalon
force-pushed
the
przemek/cuda-fix-start-events-on-enqueue-commands
branch
from
c96817a to
928a613
Compare
Added check in |
@bader Updated |
bader
approved these changes
Jul 9, 2020
romanovvlad
approved these changes
Jul 9, 2020
przemektmalon
deleted the
przemek/cuda-fix-start-events-on-enqueue-commands
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit ensures that
piEnqueueMemBufferCopy,piEnqueueMemBufferFilland other commands callstart()andrecord()correctly if events arerequested from them.
Some command types are also changed to reflect the
actual command, for example
cuda_piEnqueueMemBufferReadRectnot using the
RECTversion of the buffer readcommand type.
Some event parameter names are also changed to provide
naming consistency throughout the code.
Signed-off-by: Przemek Malon [email protected]