[Driver][SYCL] Enable use of response files for sycl link step #2052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AGindinson
previously approved these changes
Jul 7, 2020
|
@mdtoguchi, as a second thought, should |
Done - good suggestion! |
It was found that with large command lines, with large numbers of files, The default response file usage for sycl-link would end up failing at the llvm-link stage due to the length of the command line. All of the tools within the sycl-link step (clang-offload-wrapper, llvm-link, llvm-spirv, llc) all support full response files. Go ahead and enable usage of full response files for sycl-link. Signed-off-by: Michael D Toguchi <[email protected]>
Signed-off-by: Michael D Toguchi <[email protected]>
|
Looks like the response file usage has been updated. The setting is now at the addCommand level opposed to the tool level. Modifications coming soon. |
Signed-off-by: Michael D Toguchi <[email protected]>
mdtoguchi
force-pushed
the
private/mdtoguchi/sycl-link-response-file
branch
from
f280bbb to
ec11f49
Compare
|
Whoops, sorry, I've somehow missed out on the latest branch update. |
AGindinson
approved these changes
Jul 9, 2020
Chenyang-L
pushed a commit
that referenced
this pull request
Jun 23, 2023
In SPIRVReader, we erase unused functions pretty late, but we were applying the ExtInst for `--spirv-preserve-auxdata` after that, causing us to try to work on a deleted function which lead to a crash. This isn't a problem for the SPIRVWriter case because the unused function deletion happens way earlier. Signed-off-by: Sarnie, Nick <[email protected]> Original commit: KhronosGroup/SPIRV-LLVM-Translator@9823690
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was found that with large command lines, with large numbers of files,
The default response file usage for sycl-link would end up failing at
the llvm-link stage due to the length of the command line. All of the
tools within the sycl-link step (clang-offload-wrapper, llvm-link,
llvm-spirv, llc) all support full response files. Go ahead and enable
usage of full response files for sycl-link.
Signed-off-by: Michael D Toguchi [email protected]