Skip to content

[SYCL] Adding support for buffer::use_pinned_host_memory property #2080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 22, 2020
Merged

[SYCL] Adding support for buffer::use_pinned_host_memory property #2080

merged 8 commits into from
Jul 22, 2020

Conversation

romanovvlad
Copy link
Contributor

@romanovvlad romanovvlad commented Jul 9, 2020 •
edited
Loading

See the doc in the patch.

@romanovvlad romanovvlad requested a review from jbrodman July 9, 2020 16:35
@romanovvlad romanovvlad changed the title [SYCL] Adding support for buffer::use_pinned_host_memory property [WIP] [SYCL] Adding support for buffer::use_pinned_host_memory property Jul 9, 2020
@romanovvlad romanovvlad force-pushed the private/vromanov/UsePinnedMemProp branch from 3171095 to 6772c34 Compare July 15, 2020 14:15
@romanovvlad romanovvlad force-pushed the private/vromanov/UsePinnedMemProp branch from 6772c34 to eaa2ed7 Compare July 20, 2020 18:35
@romanovvlad romanovvlad marked this pull request as ready for review July 20, 2020 18:36
@romanovvlad romanovvlad requested review from mkinsner and a team as code owners July 20, 2020 18:36
@romanovvlad romanovvlad requested a review from vladimirlaz July 20, 2020 18:36
@romanovvlad romanovvlad changed the title [WIP] [SYCL] Adding support for buffer::use_pinned_host_memory property [SYCL] Adding support for buffer::use_pinned_host_memory property Jul 20, 2020
@vladimirlaz
Copy link
Contributor

please fix clang-format issue

@vladimirlaz vladimirlaz requested a review from alexbatashev July 21, 2020 05:16
alexbatashev
alexbatashev previously approved these changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@alexbatashev alexbatashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@romanovvlad romanovvlad requested a review from alexbatashev July 21, 2020 10:19
alexbatashev
alexbatashev previously approved these changes Jul 21, 2020
View reviewed changes
jbrodman
jbrodman approved these changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@jbrodman jbrodman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@romanovvlad romanovvlad merged commit e5ea144 into intel:sycl Jul 22, 2020
jsji pushed a commit that referenced this pull request Jul 17, 2023
@MrSidims @sys-ce-bb
Correctly use cached DICompilationUnit (#2080)
e85dd11 
Followup for
KhronosGroup/SPIRV-LLVM-Translator#2072

Signed-off-by: Sidorov, Dmitry <[email protected]>

Original commit:
KhronosGroup/SPIRV-LLVM-Translator@8dcd16c
jsji pushed a commit that referenced this pull request Aug 11, 2023
@MrSidims @jsji
Correctly use cached DICompilationUnit (#2080)
90f3f9c 
Followup for
KhronosGroup/SPIRV-LLVM-Translator#2072

Signed-off-by: Sidorov, Dmitry <[email protected]>

Original commit:
KhronosGroup/SPIRV-LLVM-Translator@8dcd16c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexbatashev alexbatashev alexbatashev approved these changes

@jbrodman jbrodman jbrodman approved these changes

@mkinsner mkinsner Awaiting requested review from mkinsner

@vladimirlaz vladimirlaz Awaiting requested review from vladimirlaz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@romanovvlad @vladimirlaz @alexbatashev @jbrodman